Skip to content

[BugFix] Fix multi async save in MultiConnector#90

Merged
njhill merged 1 commit intoneuralmagic:pd-launch-branchfrom
njhill:pdl-fix-multi-connector
May 16, 2025
Merged

[BugFix] Fix multi async save in MultiConnector#90
njhill merged 1 commit intoneuralmagic:pd-launch-branchfrom
njhill:pdl-fix-multi-connector

Conversation

@njhill
Copy link

@njhill njhill commented May 16, 2025

The MultiKVConnector impl keeps track of cases where multiple connectors are async saving the same request, but this state needs to be shared from the scheduler side to the worker side.

The MultiKVConnector impl keeps track of cases where multiple connectors are async saving the same request, but this state needs to be shared from the scheduler side to the worker side.

Signed-off-by: Nick Hill <nhill@redhat.com>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@njhill njhill merged commit 3032553 into neuralmagic:pd-launch-branch May 16, 2025
4 checks passed
@njhill njhill deleted the pdl-fix-multi-connector branch May 16, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants