feat: add query IDs filter

[dcb9]

Currently relayer handles all queries in specified smart contracts, but that is not enough in some circumstances, such as in a big SaaS project, users may only want to relay for specific queries in the contracts. This feature complements to RELAYER_REGISTRY_ADDRESSES to further filter out messages being processed.
If the PR is approved I'll update the doc accordingly.

[pr0n00gler]

Thanks, we'll review it shortly!

[dcb9]

@sotnikov-s Thanks for your thorough reviews :). Changes have been made.

[sotnikov-s]

thank you very much! we'll test the feature and get back to you with more info

[joldie777]

The filter works great!

I used test_kv_query script to create several smart-contracts, each with a registered interchain query. After that, I've checked the filter with different combinations of the received smart-contract addresses and query IDs. And every time I got the expected result.

For example, let's say we have the following:

• smart-contract with address="address1" which owns the registered query with ID="1"
• smart-contract with address="address2" which owns the registered query with ID="2"

============================================================================================

For envs set as:

RELAYER_REGISTRY_ADDRESSES=address1,address2
RELAYER_REGISTRY_QUERY_IDS=1,2

or

RELAYER_REGISTRY_ADDRESSES=address1,address2
RELAYER_REGISTRY_QUERY_IDS=

or

RELAYER_REGISTRY_ADDRESSES=
RELAYER_REGISTRY_QUERY_IDS=1,2

ICQ processes queries with ID="1" and ID="2"

============================================================================================

For envs set as:

RELAYER_REGISTRY_ADDRESSES=address1
RELAYER_REGISTRY_QUERY_IDS=1,2

or

RELAYER_REGISTRY_ADDRESSES=address1,address2
RELAYER_REGISTRY_QUERY_IDS=1

ICQ processes only the query with ID="1"

============================================================================================

For envs set as:

RELAYER_REGISTRY_ADDRESSES=address2
RELAYER_REGISTRY_QUERY_IDS=1,2

or

RELAYER_REGISTRY_ADDRESSES=address1,address2
RELAYER_REGISTRY_QUERY_IDS=2

ICQ processes only the query with ID="2"

============================================================================================

[dcb9]

@joldie777 Thank you for your test and feeback! The procedure and the test cases are very concise and easy to reproduce. And we are delighted to contribute to Neutron eco!

[joldie777]

@dcb9 Thank you for your contribution!

[pr0n00gler]

The PR looks great, thanks!

But could you add a simple unit test to cover new functionality?

If the PR is approved I'll update the doc accordingly.

Also please the documentation

[dcb9]

Hi @pr0n00gler here is the PR for doc neutron-org/neutron-docs#171
About unit test I'm not sure where should I put, do you mean neutron-integration-tests repo?

[pr0n00gler]

Hi @pr0n00gler here is the PR for doc neutron-org/neutron-docs#171

Thx, the doc PR is approved!

About unit test I'm not sure where should I put, do you mean neutron-integration-tests repo?

No, just a basic unit test that covers a functionality you introduced (that some queries are being filter out basically).
You can use this PR as references for the tests.

We are going to cover almost everything with unit tests and these PRs is a good start for that

[dcb9]

That's great, the PR set a good foundation, specifically it separated the implementations of RpcHttpClient and RestHttpQuery. This abstraction is required to mock test data for Subscriber.Subscribe, so should I use this PR as a base to develop the unit test(use git merge or rebase)?

[pr0n00gler]

That's great, the PR set a good foundation, specifically it separated the implementations of RpcHttpClient and RestHttpQuery. This abstraction is required to mock test data for Subscriber.Subscribe, so should I use this PR as a base to develop the unit test(use git merge or rebase)?

We've merged the PR, so you can just merge main into your branch and implement the test!

[dcb9]

Unit tests added, and it works perfectly!

[sotnikov-s]

sorry for such a delayed response and thank you very much for contribution!