-
Notifications
You must be signed in to change notification settings - Fork 0
[NR-383508] Sync develop branch with main branch #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded as part of CI/CD
[NR-344385] Support deployment of lambda templates from local setup
…-part-1-test [NR-334397] Cloudformation Templates E2E Tests - Set Up
[NR-347440] CFN template validate lambda integration logs
…mplates (#22) * added tests for metrics and lambda stacks * fixes * reverted change made to test * parallelized running tests * fixes * fixes * fixes * fixes * fixes * fixes * fixes * fixes * fixes * reverting previous changes post testing * removed chmod command
rohit-bandlamudi-nr
previously approved these changes
Mar 27, 2025
Why tests are failing? |
maya-jha
requested changes
Apr 2, 2025
hrai-nr
previously approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
voorepreethi
previously approved these changes
Apr 7, 2025
* fixed validate template step and lambda-template.yaml validate errors * removed slack notification and made e2e tests run on pull request * added develop branch to test e2e tests * removing changes made for testing
hrai-nr
approved these changes
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maya-jha
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is used to merge all changes in develop to main. The changes include:
Action items on PR: