Skip to content

[NR-383508] Sync develop branch with main branch #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 79 commits into from
Apr 15, 2025
Merged

[NR-383508] Sync develop branch with main branch #24

merged 79 commits into from
Apr 15, 2025

Conversation

ahegdeNR
Copy link
Contributor

@ahegdeNR ahegdeNR commented Mar 27, 2025

This PR is used to merge all changes in develop to main. The changes include:

  1. Local template deployment support
  2. Parsing requestID from logs
  3. E2E test PRs:
  1. Updating version from yaml file

Action items on PR:

  • Validate E2E tests run successfully based on rule set on github -> successfully ran the tests here
  • Validate manually from UI after the code is merged

[NR-344385] Support deployment of lambda templates from local setup
…-part-1-test

[NR-334397] Cloudformation Templates E2E Tests - Set Up
ahegdeNR and others added 11 commits February 11, 2025 07:20
[NR-347440] CFN template validate lambda integration logs
…mplates (#22)

* added tests for metrics and lambda stacks

* fixes

* reverted change made to test

* parallelized running tests

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* reverting previous changes post testing

* removed chmod command
@ahegdeNR ahegdeNR self-assigned this Mar 27, 2025
@maya-jha
Copy link
Contributor

Why tests are failing?

hrai-nr
hrai-nr previously approved these changes Apr 7, 2025
Copy link
Contributor

@hrai-nr hrai-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

voorepreethi
voorepreethi previously approved these changes Apr 7, 2025
* fixed validate template step and lambda-template.yaml validate errors

* removed slack notification and made e2e tests run on pull request

* added develop branch to test e2e tests

* removing changes made for testing
@ahegdeNR ahegdeNR dismissed stale reviews from voorepreethi and hrai-nr via 19e2eb2 April 9, 2025 12:02
Copy link
Contributor

@hrai-nr hrai-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahegdeNR ahegdeNR requested a review from maya-jha April 15, 2025 08:55
@ahegdeNR ahegdeNR merged commit b43d7eb into main Apr 15, 2025
59 checks passed
@hrai-nr hrai-nr deleted the develop branch May 6, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants