Skip to content

Conversation

@ahegdeNR
Copy link
Contributor

Inline lambdas create log groups to post errors during cloud formation template deployment.

  1. Added retention period of 14 days.
  2. Created deletion policy so log groups get deleted when stack is deleted.

@sanathramesh sanathramesh self-requested a review October 23, 2025 09:14
Copy link
Contributor

@hrai-nr hrai-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the instrumentation version as well in version.go and e2e test case related file.
Also change the property SemanticVersion, in all the template files, else it will fail.

Type: AWS::Logs::LogGroup
DeletionPolicy: Delete
Properties:
LogGroupName: !Sub "/aws/lambda/${NewRelicLogsServerlessLogForwarder}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing property RetentionInDays: 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants