Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new rules for dynamoDb for map NR Lambda function relationships #1889

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

francis2211
Copy link

Relevant information
--> Currently we are working with mapping relationships for Lambda functions. As part of it, I'm trying to adding new rules for DynamoDB and S3 calls.
--> Please review this PR & provide the feedback on it, And also guid me for further assistance.

Relevant information
--> Currently we are working with mapping relationships for Lambda functions. As part of it, I'm trying to adding new rules for DynamoDB  calls.
--> Please review this PR & provide the feedback on it, And also guid me for further assistance.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect filename. Format must be ORIGIN-to-TARGET: AWS-LAMBDA-SPAN-to-DYNAMODB.yml

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect filename. Format must be ORIGIN-to-TARGET: AWS-LAMBDA-SPAN-to-DYNAMODB.yml

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect filename. Format must be ORIGIN-to-TARGET: AWS-LAMBDA-SPAN-to-DYNAMODB.yml

Comment on lines +14 to +17
attribute: entity.guid
target:
extractGuid:
attribute: entity.guid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will do a realtionship on itself. is that what you really want??

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want a relashionsip from lambda to Dynamo. could you suggest a change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@francis2211 we cannot support you without proper understanding which metrics you want to use. Could you please reach out via #help-relationship-platform on our internal Slack?

Comment on lines +7 to +8
- attribute: name
regex: "*dynamodb*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the best condition we can get? how can you identify from the telemetry that it comes from dynamo other than this regex?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants