Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: defensively handle null source address in MassTransit instrumentation #2060

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

nr-ahemsath
Copy link
Member

@nr-ahemsath nr-ahemsath commented Nov 13, 2023

BEGIN_COMMIT_OVERRIDE
fix: Defensively handle null source address in MassTransit instrumentation. (#2055)
END_COMMIT_OVERRIDE

Fixes #2055 by checking for a null source address before attempting to use it to get the queue name and type. If the source address is null, the queue name will be "Unknown" and the type will be "Queue".

I added a story to the backlog to revisit the issue of queue naming when time permits: #2061

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Merging #2060 (dabf9a6) into main (d0b8d26) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2060      +/-   ##
==========================================
- Coverage   81.06%   81.05%   -0.01%     
==========================================
  Files         394      395       +1     
  Lines       24678    24697      +19     
  Branches     2963     2966       +3     
==========================================
+ Hits        20004    20017      +13     
- Misses       3889     3892       +3     
- Partials      785      788       +3     
Files Coverage Δ
...s/NewRelic.Agent.Extensions/Helpers/MassTransit.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@nr-ahemsath nr-ahemsath merged commit 0249582 into main Nov 14, 2023
@nr-ahemsath nr-ahemsath deleted the fix/masstransit-handle-null-sourceaddress branch November 14, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Object reference error occurs when a MassTransit message is received without an envelope.
10 participants