-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: defensively handle null source address in MassTransit instrumentation #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
reviewed
Nov 13, 2023
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/MassTransit/MassTransitHelpers.cs
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
- Coverage 81.06% 81.05% -0.01%
==========================================
Files 394 395 +1
Lines 24678 24697 +19
Branches 2963 2966 +3
==========================================
+ Hits 20004 20017 +13
- Misses 3889 3892 +3
- Partials 785 788 +3
|
tippmar-nr
approved these changes
Nov 13, 2023
chynesNR
approved these changes
Nov 13, 2023
jaffinito
approved these changes
Nov 13, 2023
Added unit tests
chynesNR
approved these changes
Nov 13, 2023
ilhancengiz
approved these changes
Nov 14, 2023
zikriyeurkmezcengiz
approved these changes
Nov 14, 2023
dekabe
approved these changes
Nov 14, 2023
keremdokumaci
approved these changes
Nov 14, 2023
chynesNR
approved these changes
Nov 14, 2023
nrcventura
approved these changes
Nov 14, 2023
jaffinito
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Defensively handle null source address in MassTransit instrumentation. (#2055)
END_COMMIT_OVERRIDE
Fixes #2055 by checking for a null source address before attempting to use it to get the queue name and type. If the source address is null, the queue name will be "Unknown" and the type will be "Queue".
I added a story to the backlog to revisit the issue of queue naming when time permits: #2061