chore: Update Profiler projects to build on VS2022 #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2149 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 396 396
Lines 24723 24723
Branches 2997 2997
=======================================
Hits 20034 20034
Misses 3899 3899
Partials 790 790 |
tippmar-nr
changed the title
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
chynesNR
approved these changes
Jan 4, 2024
Co-authored-by: tippmar-nr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Profiler solution and project files so the Profiler can be built directly in VS2022. There are 2 lines of code that had to be commented out to get the build to complete. I also updated three .NET projects to target net48 instead of net45, which allows them to build under VS2022 as well.
The
build_profiler.ymlworkflow was updated to run the Windows profiler build onwindows-latest.No other changes were necessary for the linux and ARM64 builds.
There were also some workflow changes necessary to accommodate this change.