ci: Configure CodeQL Workflow, Unify <langVersion> #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
tippmar-nr
requested review from
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
chynesNR
approved these changes
Dec 21, 2023
|
Holding this PR until @nrcventura has a chance to review and chime in on the |
nr-ahemsath
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new workflow to run CodeQL, superseding the "default" configuration that was recently enabled for all repos in the New Relic org.
For the time being, we will only scan C# projects, as we can (apparently) have only a single CodeQL workflow per repo, and our C++ projects have to build on Windows 2019, while our C# projects have to build on Windows 2022.I was able to get the scan to run on both C# and C++. Yay!
Results for the analysis on this PR are at: https://github.com/newrelic/newrelic-dotnet-agent/security/code-scanning?query=tool%3ACodeQL+pr%3A2159 -- there doesn't seem to be anything for C++, so I guess that code is solid. The other items reported for C# are either used in tests or false positives.
The other (somewhat huge) set of changes in this PR is to eliminate explicit use of
<langVersion>attributes in .csproj files (which specified wildly different versions), in favor of a single, unified<langVersion>default</langVersion>in the baseDirectory.Build.propsfile. Aside from ensuring that all projects build with the correct language version (based on the tfm), this also helps alleviate some issues with the CodeQL scanning tool, as it was unhappy about using certain hard-coded language versions.