Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flicker in SpanStreamingServiceTests #2167

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

tippmar-nr
Copy link
Member

Multiple threads were trying to add to the (unsynchronized) List<T>. A ConcurrentBag<T> fixed that right smart quick...

Copy link
Member

@nr-ahemsath nr-ahemsath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tippmar-nr tippmar-nr enabled auto-merge (squash) January 3, 2024 20:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40bf464) 81.05% compared to head (e534ef6) 81.05%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2167   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files         396      396           
  Lines       24723    24723           
  Branches     2969     2969           
=======================================
  Hits        20038    20038           
  Misses       3899     3899           
  Partials      786      786           

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tippmar-nr tippmar-nr merged commit 77d7e5c into main Jan 3, 2024
74 checks passed
@tippmar-nr tippmar-nr deleted the test/unit-test-flicker branch January 3, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants