Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding MariaDB dashboard and alert conditions #2139

Merged
merged 24 commits into from
Jan 10, 2024
Merged

Adding MariaDB dashboard and alert conditions #2139

merged 24 commits into from
Jan 10, 2024

Conversation

harrykimpel
Copy link
Contributor

Summary

Adding MariaDB dashboard and alert conditions to the already existing quickstart. The existing quickstart only included a link to the docs page for MySQL.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

rahulbasu-nr
rahulbasu-nr suggested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these changes.

dashboards/mariadb/mariadb.png Outdated Show resolved Hide resolved
dashboards/mariadb/mariadb.json Outdated Show resolved Hide resolved
@harrykimpel
Copy link
Contributor Author

Please make these changes.

@rahulbasu-nr changes made

mickeyryan42
mickeyryan42 suggested changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@mickeyryan42 mickeyryan42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, could we first please update these file names to be lower case with dashes instead of spaces per the convention in the repo?

@harrykimpel
Copy link
Contributor Author

This looks good to me, could we first please update these file names to be lower case with dashes instead of spaces per the convention in the repo?

done

rahulbasu-nr
rahulbasu-nr previously approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@rahulbasu-nr rahulbasu-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

mickeyryan42
mickeyryan42 previously approved these changes Nov 14, 2023
View reviewed changes
sarahkitten
sarahkitten suggested changes Nov 14, 2023
View reviewed changes
quickstarts/k6-prometheus/config.yml Outdated Show resolved Hide resolved
@harrykimpel
Copy link
Contributor Author

I just had a few notes on this one, otherwise it looks good to me.

just pushed some updates

@harrykimpel harrykimpel requested a review from d3caf November 27, 2023 16:07
RamanaReddy8801
RamanaReddy8801 reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harrykimpel, Please make these changes.

alert-policies/mariadb/innodb-pending-reads-and-writes.yml Outdated Show resolved Hide resolved
data-sources/k6-prometheus/config.yml Show resolved Hide resolved
quickstarts/k6-prometheus/config.yml Outdated Show resolved Hide resolved
@harrykimpel
Minor changes to descriptions
11b017a 
Signed-off-by: Harry Kimpel <[email protected]>
@harrykimpel
Copy link
Contributor Author

@harrykimpel, Please make these changes.

@RamanaReddy8801 done

RamanaReddy8801
RamanaReddy8801 previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdumpati
mdumpati previously approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@mdumpati mdumpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

The PR checks have run and found the following warnings:

Warning Filepath
"permissions" field should not be used dashboards/windows-certs/windows-certs-expiration.json

Reference the Contributing Docs for Dashboards for more information.

@harrykimpel
Removing permissions field
7c48450 
Signed-off-by: Harry Kimpel <[email protected]>
@harrykimpel harrykimpel dismissed stale reviews from mdumpati and RamanaReddy8801 via 7c48450 December 18, 2023 06:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Jan 6, 2024
@harrykimpel
Copy link
Contributor Author

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

pls. keep this open and review once again

@github-actions github-actions bot removed the stale label Jan 9, 2024
@aswanson-nr aswanson-nr merged commit 503d5c4 into newrelic:main Jan 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosanam pkosanam pkosanam left review comments

@sarahkitten sarahkitten sarahkitten approved these changes

@aswanson-nr aswanson-nr aswanson-nr approved these changes

@mdumpati mdumpati mdumpati left review comments

@mickeyryan42 mickeyryan42 mickeyryan42 left review comments

@RamanaReddy8801 RamanaReddy8801 RamanaReddy8801 left review comments

@seemantk seemantk Awaiting requested review from seemantk

@d3caf d3caf Awaiting requested review from d3caf

@rahulbasu-nr rahulbasu-nr Awaiting requested review from rahulbasu-nr

Assignees
No one assigned
Labels
improved-quickstart waiting on contributor
Projects
NR1 Quickstarts Community
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@harrykimpel @d3caf @sarahkitten @aswanson-nr @mdumpati @pkosanam @rahulbasu-nr @mickeyryan42 @RamanaReddy8801