Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing query for http connections #2150

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Changing query for http connections #2150

merged 4 commits into from
Jan 9, 2024

Conversation

MahithaB
Copy link
Contributor

Summary

Changing NRQL query for HTTP connections widget in jfrog-artifactory dashboard for jfrog-platform quickstart

@MahithaB MahithaB requested a review from seemantk as a code owner November 21, 2023 22:10
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

MichelLosier
MichelLosier reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@MichelLosier MichelLosier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just need the CLA signed!

@MahithaB
Copy link
Contributor Author

@MichelLosier I've signed the CLA and got a thank you message as response. However, the status is not reflected. Can you please help me out? Thanks!

@MichelLosier
Copy link
Contributor

In the CLA message above - could you try the link in the message:

You have signed the CLA already but the status is still pending? Let us recheck it.

Sounds like that might help here

@MahithaB
Copy link
Contributor Author

@MichelLosier the link helps and I can finally see the CLA signed being reflected in the status. Thank you!

MichelLosier
MichelLosier previously approved these changes Dec 1, 2023
View reviewed changes
@MahithaB
Copy link
Contributor Author

@MichelLosier could you give me the timeline for freeze? Thanks!

@github-actions GitHub Actions
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@github-actions github-actions bot added the stale label Dec 28, 2023
@MahithaB
Copy link
Contributor Author

@MichelLosier @seemantk can you please review the PR. Thanks!

@github-actions github-actions bot removed the stale label Jan 1, 2024
jcountsNR
jcountsNR previously approved these changes Jan 4, 2024
View reviewed changes
@sarahkitten sarahkitten changed the base branch from main to release January 9, 2024 17:46
@sarahkitten sarahkitten dismissed stale reviews from jcountsNR and MichelLosier January 9, 2024 17:46

The base branch was changed.

@sarahkitten sarahkitten merged commit 517a7b0 into newrelic:release Jan 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahkitten sarahkitten sarahkitten approved these changes

@jcountsNR jcountsNR jcountsNR left review comments

@seemantk seemantk Awaiting requested review from seemantk

@MichelLosier MichelLosier Awaiting requested review from MichelLosier

Assignees
No one assigned
Labels
awaiting freeze end product partnerships
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MahithaB @CLAassistant @MichelLosier @sarahkitten @jcountsNR