-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NR-305852 Check for missing quickstart IDs #2550
Conversation
…tarts into mickey/NR-305852-quickstart-ids
fff1b4c
to
7214731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out e2e on my fork and worked as expected 👍
Question: is this actually redundant, though? The schema validation ensures that quickstarts have IDs already. |
@@ -15,3 +15,16 @@ jobs: | |||
uses: "./.github/actions/bootstrap" | |||
- name: Validate PR Artifact | |||
uses: "./.github/actions/build-validate-artifact" | |||
validate-quickstart-ids: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question about the pipeline on this:
Will this run before or after we generate a UUID for a new quickstart? We have a workflow that generates after the quickstart has been merged through.
Not sure if now with the changes it happens on pr -> release branch or if its still ran on release -> pr
This made me think, what if its a new quickstart being created? We don't have an ID for that quickstart yet |
We have a workflow that runs on merge to the release branch, creates IDs and commits them back to the branch. So maybe we need to think about excluding that validation from this branch or something, and only validate on merge to main? |
Update after standup: we're not going to require |
https://new-relic.atlassian.net/browse/NR-305852
Summary
The job runs conditionally in PRs when the base is
main
and the head ref isrelease
and validates that all quickstarts have IDs. Also removing the requirement for theid
on quickstarts because it isn't required at PR time and they're generated later. We cant remove the id entirely because then when we validate on the main branch it'll fail, so i've just made them optional.