Feat performance monitoring #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tharun0064
force-pushed
the
feat_performance_monitoring
branch
3 times, most recently
from
a3610b4 to
a920d40
Compare
rahulreddy15
changed the base branch from
master
to
epic_db_query_performance_monitoring
There was a problem hiding this comment.
Hi, I only reviewed the new code, and would not have 100% confidence on any impacts on the older code. Therefore, additional reviews would be required.
- As pointed by the linter, some files are not formatted correctly.
- It is difficult to assert and understand the logic without any comments or unit tests. Can we please add unit tests for all logical functions and utils. Please add any comments helpful to understand what's going on :).
- I also see some code duplication as pointed by the linter as well. We should check if that can be removed.
- If we can, I think it can be refactored to only check for version once as the integration is running for a single DBMS, and build our struct based on that, which can still have the same functions for getting query metrics. But use different adapters based on the version. This could remove some duplication and improve readability.
- It would be helpful if the PR description is updated with some more details and testing details.
Thanks
src/query-performance-monitoring/common-utils/common-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/query-fetch-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/query-fetch-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics/execution_plan_metrics.go
Outdated
Show resolved
Hide resolved
tharun0064
reviewed
Jan 9, 2025
There was a problem hiding this comment.
@rajrohanyadav
Thanks for reviewing the PR
can you mention the comments with criticality as P0 ,P1 etc
we will work on them accordingly
P0 - Unit tests |
tharun0064
reviewed
Jan 15, 2025
src/query-performance-monitoring/common-utils/common-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/common-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/common-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/ingestion-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/ingestion-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/ingestion-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/ingestion-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/common-utils/query-fetch-helpers.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics/individual_query_metrics.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics/individual_query_metrics_test.go
Outdated
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics/individual_query_metrics.go
Outdated
Show resolved
Hide resolved
rahulreddy15
force-pushed
the
feat_performance_monitoring
branch
from
46847de to
8509bcd
Compare
* resolved: review comments
Feat: resolved review comments
* Refactored Integration Tests * Fixed linting errors * Fixed linting errors again * Fixed linting errors again again * Fixed linting errors again again again * linting is back * linting is back again * linting is back again again * linting is back again again again * linting is back again again again again
resolved : review comments
fix lint issues
Feat : resolved review comments
* resolved: refactored unit test cases
* resolved : review comments --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
fix: lint issues --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
* added more scenerios for unit test cases --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
* rename variable --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
resolved : review comments --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
* remove unused variables --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
* resolved: review comments --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
Feat: resolved review comments
* add check while fetching execution plan * resolved : lint issues --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
Fix: Resolved review comments --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
fix: lint issues
* execution plan data model fix
* add default description --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
* feat: resolved review comments * update execution plan schema * feat: change in variable name * feat: change in variable --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
* feat: resolved review commets * fix: lint issues --------- Co-authored-by: Jyothi Surampudi <[email protected]> Co-authored-by: jsurampudi <[email protected]> Co-authored-by: Rahul Reddy <[email protected]>
rahulreddy15
force-pushed
the
feat_performance_monitoring
branch
from
c2e75f1 to
58e636e
Compare
sairaj18
merged commit daf69cc
into
newrelic:epic_db_query_performance_monitoring
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to merge performance monitoring code from the fork to the branch
epic_db_query_performance_monitoring