-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step4 - 페이먼츠(카드 수정) #53
Open
oyj7677
wants to merge
18
commits into
next-step:oyj7677
Choose a base branch
from
oyj7677:Step4
base: oyj7677
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9ef8565
Refactor : 로고 및 수식자 속성으로 구성요소 유연성 향상
oyj7677 2343f5c
Refactor : Card 데이트 클래스 프로퍼티 변경 및 카드 등록 로직 변경
oyj7677 3cbdfb5
Refactor : 카드 이미지 컴포넌트 수정
oyj7677 af3e538
Refactor : 단일 카드 노출 컴포넌트 수정
oyj7677 366b597
Refactor : 등록 카드 회사명 추가
oyj7677 9a10420
Chore : README.md 수정
oyj7677 9e3eaa0
Chore : Step4 (카드수정) 기능 목록 추가
oyj7677 d319fbb
Feat : 등록 카드 선택 시 카드 등록 화면으로 이동.
oyj7677 c577a00
Chore : README.md 수정
oyj7677 73c0d77
Fix : 한장 이상의 카드 화면에서 카드 선택시 화면 이동 안하던 이슈 해결
oyj7677 b328592
Feat : 등록된 카드 수정 기능 구현
oyj7677 9fcbb3d
Refactor : 등록된 카드 수정 기능 리펙토링
oyj7677 8a81524
Chore : README.me 수정
oyj7677 aa82010
Chore : 리뷰 반영
oyj7677 1b91e7f
Refactor : 카드 저장 로직 수정
oyj7677 12b22a6
Refactor : 리뷰 반영
oyj7677 4a39882
Refactor : 카드 목록, 카드 등록 데이터 보존 기능 추가
oyj7677 656f36a
Refactor : 카드 저장 uiState 상태 저장 로직 변경 및 네이밍 변경
oyj7677 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
app/src/main/java/nextstep/payments/data/RegisteredCreditCards.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Activity와 AAC ViewModel의 LifeCycle은 별도로 굴러가기 때문에 이러한 코드는 작성하지 않으셔도 됩니다. 🙂