-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 3단계 - 기능 우선 패키지 구성하기 #510
base: sumiini
Are you sure you want to change the base?
Changes from all commits
9c59995
efe6862
638b1f0
aca1874
827a45b
73441c4
87c895c
33891ad
fb9d578
e761508
3a4289a
567747a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package kitchenpos.infra; | ||
package kitchenpos.global.infra; | ||
|
||
import org.springframework.stereotype.Component; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package kitchenpos.infra; | ||
package kitchenpos.global.infra; | ||
|
||
import java.math.BigDecimal; | ||
import java.util.UUID; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
package kitchenpos.domain; | ||
package kitchenpos.menu.infra; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Repository는 비즈니스 규칙을 반영하기에 infra 레이어가 적합하지 않은 것 같아요🧐 |
||
|
||
import kitchenpos.menu.domain.Menu; | ||
|
||
import java.util.List; | ||
import java.util.Optional; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
package kitchenpos.application; | ||
package kitchenpos.menugroup.application; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Menu와 MenuGroup을 다른 컨텍스트로 분리하신 이유가 궁금해요! |
||
|
||
import kitchenpos.domain.MenuGroup; | ||
import kitchenpos.domain.MenuGroupRepository; | ||
import kitchenpos.menugroup.domain.MenuGroup; | ||
import kitchenpos.menugroup.infra.MenuGroupRepository; | ||
import org.springframework.stereotype.Service; | ||
import org.springframework.transaction.annotation.Transactional; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package kitchenpos.domain; | ||
package kitchenpos.order.domain; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 모델링을 하실 때, 주문 유형별로 모델링을 분리해보셨는데, |
||
|
||
public enum OrderStatus { | ||
WAITING, ACCEPTED, SERVED, DELIVERING, DELIVERED, COMPLETED | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package kitchenpos.domain; | ||
package kitchenpos.order.domain; | ||
|
||
public enum OrderType { | ||
DELIVERY, TAKEOUT, EAT_IN | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
package kitchenpos.application; | ||
package kitchenpos.ordertable.application; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OrderTable을 별도의 컨텍스트로 분리하신 이유도 궁금해요! |
||
|
||
import kitchenpos.domain.OrderRepository; | ||
import kitchenpos.domain.OrderStatus; | ||
import kitchenpos.domain.OrderTable; | ||
import kitchenpos.domain.OrderTableRepository; | ||
import kitchenpos.order.infra.OrderRepository; | ||
import kitchenpos.order.domain.OrderStatus; | ||
import kitchenpos.ordertable.domain.OrderTable; | ||
import kitchenpos.ordertable.infra.OrderTableRepository; | ||
import org.springframework.stereotype.Service; | ||
import org.springframework.transaction.annotation.Transactional; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
package kitchenpos.application; | ||
package kitchenpos.product.application; | ||
|
||
import kitchenpos.domain.Menu; | ||
import kitchenpos.domain.MenuProduct; | ||
import kitchenpos.domain.MenuRepository; | ||
import kitchenpos.domain.Product; | ||
import kitchenpos.domain.ProductRepository; | ||
import kitchenpos.infra.PurgomalumClient; | ||
import kitchenpos.menu.domain.Menu; | ||
import kitchenpos.menu.domain.MenuProduct; | ||
import kitchenpos.menu.infra.MenuRepository; | ||
import kitchenpos.product.domain.Product; | ||
import kitchenpos.product.infra.ProductRepository; | ||
import kitchenpos.global.infra.PurgomalumClient; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. productService가 인프라 레이어를 직접 참조하고 있군요. |
||
import org.springframework.stereotype.Service; | ||
import org.springframework.transaction.annotation.Transactional; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Menu 컨텍스트가 Product 컨텍스트를 직접 참조하고 있네요!
이 경우는 어떻게 풀어볼 수 있을까요?