Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix Search Not Working When Sharing File From Outside of the App #12162

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 13, 2023

Steps to Reproduce

  1. Open native file app of the device
  2. Select a file or files
  3. Tap share icon from native files app
  4. Select Nextcloud App from bottom-sheet
  5. Try search

@tobiasKaminsky @ZetaTom In adapter I saw logic for setting thumbnail for Images already exist in user's root directory. However for upload user can only choose folder and user can't select image for upload path. IMO we should only show directories. What do you think about it?

Before

before.mov

After

after.mov
  • Tests written, or not not needed

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@JonasMayerDev
Copy link
Collaborator

JonasMayerDev commented Nov 30, 2023

I have problems when navigating too fast that the reload of the files / directory closes the search bar. So when navigating in a new folder and then clicking directly on search I can start typing something but after around 2 second (when files reload) the search bar gets closed, but keyboard is still open. This leads to frustrating interactions where one typed out a name only to see that you have to type it again because the search was closed and the typed text got deleted because you were "too fast".

Maybe it's possible to not close the search bar when reloading the files or at least close the keyboard when the search bar is closed, so the user does not type something without effect...

I don't know if this is a big problem, just a bit frustrating when you have a lot of nested folders you want to upload to. Everything else works perfectly and solves the issue.

issue.mp4

Signed-off-by: alperozturk <[email protected]>
Copy link
Collaborator

@JonasMayerDev JonasMayerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the Bug!

@tobiasKaminsky
Copy link
Member

/rebase

Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Copy link
Collaborator Author

/backport to stable-3.27

Copy link

github-actions bot commented Dec 6, 2023

Codacy

Lint

TypemasterPR
Warnings7575
Errors99

SpotBugs

CategoryBaseNew
Bad practice2626
Correctness7069
Dodgy code359359
Experimental22
Internationalization99
Malicious code vulnerability22
Multithreaded correctness99
Performance5858
Security1818
Total553552

Copy link

github-actions bot commented Dec 6, 2023

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12162.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger merged commit b98db41 into master Dec 6, 2023
19 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/search-not-working-when-sharing-outside-of-the-app branch December 6, 2023 11:48
@tobiasKaminsky
Copy link
Member

/backport to stable-3.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants