-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix Search Not Working When Sharing File From Outside of the App #12162
Bugfix Search Not Working When Sharing File From Outside of the App #12162
Conversation
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
I have problems when navigating too fast that the reload of the files / directory closes the search bar. So when navigating in a new folder and then clicking directly on search I can start typing something but after around 2 second (when files reload) the search bar gets closed, but keyboard is still open. This leads to frustrating interactions where one typed out a name only to see that you have to type it again because the search was closed and the typed text got deleted because you were "too fast". Maybe it's possible to not close the search bar when reloading the files or at least close the keyboard when the search bar is closed, so the user does not type something without effect... I don't know if this is a big problem, just a bit frustrating when you have a lot of nested folders you want to upload to. Everything else works perfectly and solves the issue. issue.mp4 |
Signed-off-by: alperozturk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the Bug!
/rebase |
Signed-off-by: alperozturk <[email protected]>
/backport to stable-3.27 |
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12162.apk |
/backport to stable-3.27 |
Steps to Reproduce
@tobiasKaminsky @ZetaTom In adapter I saw logic for setting thumbnail for Images already exist in user's root directory. However for upload user can only choose folder and user can't select image for upload path. IMO we should only show directories. What do you think about it?
Before
before.mov
After
after.mov