Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assistant Feature #12612

Merged
merged 98 commits into from
Mar 13, 2024
Merged

Assistant Feature #12612

merged 98 commits into from
Mar 13, 2024

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 26, 2024 •
edited
Loading

  • Tests written, or not not needed

@alperozturk96 alperozturk96 marked this pull request as draft February 26, 2024 15:19
@alperozturk96 alperozturk96 marked this pull request as ready for review February 29, 2024 14:54
@alperozturk96 alperozturk96 marked this pull request as draft February 29, 2024 14:56
@alperozturk96 alperozturk96 force-pushed the feature/assistant branch 2 times, most recently from 76963c1 to fd3765f Compare March 1, 2024 12:57
@alperozturk96 alperozturk96 marked this pull request as ready for review March 1, 2024 15:02
@alperozturk96 alperozturk96 marked this pull request as draft March 1, 2024 15:02
@alperozturk96 alperozturk96 marked this pull request as ready for review March 4, 2024 10:10
@alperozturk96 alperozturk96 force-pushed the feature/assistant branch 4 times, most recently from 445113d to 55b493a Compare March 5, 2024 07:46
@alperozturk96 alperozturk96 force-pushed the feature/assistant branch 2 times, most recently from 93134ce to 1db9dd6 Compare March 6, 2024 07:38
@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Screenshot tests are irrelevant. We can merge this because other PRs also failing because of the ss tests

@alperozturk96 alperozturk96 force-pushed the feature/assistant branch 4 times, most recently from aef2417 to ab35ea1 Compare March 11, 2024 10:32
@tobiasKaminsky
Copy link
Member

@alperozturk96 you may never change an existing DB version, in this case 78.
This would break auto migration.
Please thus revert 78 and check that an update from 3.28.0 to this branch works.

alperozturk96 and others added 14 commits March 13, 2024 09:12
@alperozturk96
Fix build errors
e474372 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Use view instead activity for ss tests
108d522 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Make AssistantViewModel testable
547a90a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix ss tests
3a842f2 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix ss tests
9ce57d9 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add new ss tests
ee066a2 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Reduce kotlin ksp version because compatiblity issue with compose com…
3fe8030 
…piler

Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Reduce kotlin ksp version because compatiblity issue with compose com…
b2b3102 
…piler

Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add new ss
dd64123 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add new ss
42d6dbc 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add new ss
3ab9241 
Signed-off-by: alperozturk <[email protected]>
@tobiasKaminsky @alperozturk96
fix database upgrade
a2b7406 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky @alperozturk96
fix database upgrade
e2b3091 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky @alperozturk96
fix database upgrade
631ddf5 
Signed-off-by: tobiasKaminsky <[email protected]>
@alperozturk96
Add multine line for add task alert dialog
6f77758 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix text for empty task list
f12657d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add assistant to header
ffe1923 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix crash when no internet connection
a959c15 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add Screen State
b50a114 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Add Assistant under the notification in drawer for branded clients
69a4500 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Check capability
3cd56c7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Fix condition
9556392 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Reduce spotbugs
d5fded1 
Signed-off-by: alperozturk <[email protected]>
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings7171
Errors33

SpotBugs

CategoryBaseNew
Bad practice6868
Correctness7169
Dodgy code351351
Experimental22
Internationalization77
Malicious code vulnerability22
Multithreaded correctness66
Performance5656
Security1919
Total582580

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12612.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12612-Screenshot-blue-Light-14-34

@tobiasKaminsky tobiasKaminsky merged commit c1c2989 into master Mar 13, 2024
18 of 20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/assistant branch March 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@JonasMayerDev JonasMayerDev Awaiting requested review from JonasMayerDev

Assignees

@alperozturk96 alperozturk96

Labels
3. to review
Projects
🤖 🍏 Mobile clients team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @ZetaTom