Bugfix Start Foreground Service When App In Foreground

[alperozturk96]

• Tests written, or not not needed

What does this PR?

Only starts foreground service when app in foreground so we don't came across background crashes anymore
No need to do it for FOREGROUND_SERVICE_MEDIA_PLAYBACK because Media Playback not causing that issue

[tobiasKaminsky]

Instead of writing own lifecycle, can't we re-use the Android one?
Like we do here:

android/app/src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.kt

Line 826 in 8bb1eaa

if (lifecycle.currentState.isAtLeast(Lifecycle.State.RESUMED)) {

[alperozturk96]

Instead of writing own lifecycle, can't we re-use the Android one? Like we do here:

android/app/src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.kt

Line 826 in 8bb1eaa

if (lifecycle.currentState.isAtLeast(Lifecycle.State.RESUMED)) {

Instead of writing own lifecycle, can't we re-use the Android one? Like we do here:

android/app/src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.kt

Line 826 in 8bb1eaa

if (lifecycle.currentState.isAtLeast(Lifecycle.State.RESUMED)) {

Instead of writing own lifecycle, can't we re-use the Android one? Like we do here:

android/app/src/main/java/com/owncloud/android/ui/activity/SyncedFoldersActivity.kt

Line 826 in 8bb1eaa

if (lifecycle.currentState.isAtLeast(Lifecycle.State.RESUMED)) {

Then we need to add this dependency "androidx.lifecycle:lifecycle-service:2.8.1" to access lifecycle from service. PR is updated.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	70	70
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	64	64
Correctness	69	69
Dodgy code	346	346
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	57	57
Security	19	19
Total	571	571

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13065.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

/backport to stable-3.29