Bugfix NPE & Convert to Kotlin SSL Untrusted Cert Dialog

[alperozturk96]

• Tests written, or not not needed

Previously SSL Untrusted Cert Dialog was java file and a lot of nullable variable used everywhere. I checked our crash reports and a lot of user affected because of NPE. This PR converts java file to Kotlin and safely uses the variables.

[tobiasKaminsky]

How can I test this dialog?
With login v1 I could use my self signed cert on test server, but now with v2?

[alperozturk96]

How can I test this dialog? With login v1 I could use my self signed cert on test server, but now with v2?

How can I test this dialog? With login v1 I could use my self signed cert on test server, but now with v2?

IDK. What's the difference for certificate between v1 and v2? Can't you create certificate for v2 manually?

I tested the dialog by calling it from FileDisplayActivity and manually creating a certificate, which I then passed to the dialog's constructor.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13076.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	70	70
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	64	64
Correctness	69	69
Dodgy code	346	343
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	6	6
Performance	57	57
Security	19	19
Total	571	568

[tobiasKaminsky]

Right… I was wrong with that one…

[alperozturk96]

/backport to stable-3.29