Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.29] Show Snackbar Message Instead Throwing Exception For Sync Folder Operations #13097

Merged
merged 2 commits into from
Jun 14, 2024
Merged

[stable-3.29] Show Snackbar Message Instead Throwing Exception For Sync Folder Operations #13097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb835f4
Show snackbar message instead throwing exception
alperozturk96 Jun 6, 2024
91ad15a
Revert
alperozturk96 Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,8 @@ public void onSavedCertificate() {

private void startSyncFolderOperation(OCFile folder) {
if (folder == null) {
throw new IllegalArgumentException("Folder must not be null");
DisplayUtils.showSnackMessage(this, R.string.receive_external_files_activity_start_sync_folder_is_not_exists_message);
return;
}

long currentSyncTime = System.currentTimeMillis();
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,8 @@
<string name="clipboard_unexpected_error">Unexpected error while copying to clipboard</string>
<string name="clipboard_label">Text copied from %1$s</string>

<string name="receive_external_files_activity_start_sync_folder_is_not_exists_message">Folder cannot be found, sync operation is cancelled</string>

<string name="error_cant_bind_to_operations_service">Critical error: Unable to perform operations</string>

<string name="network_error_socket_exception">An error occurred during connection to the server</string>
Expand Down
Loading