Improve Storage Permission Handling

[alperozturk96]

• Tests written, or not not needed

• Remove the internal boolean flag used to determine whether the app needs to request storage permission. The app should always request the necessary permission if it has not been granted.

• Simplify the StoragePermissionDialog logic by removing the external listener. The dialog’s sole responsibility should be to either open the app settings to request “Manage All Files” permission or request read-only media access. Decoupling this functionality from external listeners improves code readability and reduces complexity

• Use precise and descriptive function names to improve code clarity and maintainability

• Remove redundant checks in the requestStoragePermissionIfNeeded() function. This function already internally verifies whether storage permission is required, making additional checks unnecessary

• Remove the readOnly parameter as its logic is implicitly tied to Android 11 and above (API level 30+). The current implementation redundantly checks the same condition (readOnly && Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) multiple times, which is unnecessary and can lead to confusion

• Add READ_MEDIA_VISUAL_USER_SELECTED permission (Documentation)

Android 7 GPlay

Android 11 Generic

Android 11 GPlay

Android 15 Generic

Android 15 GPlay

[alperozturk96]

/backport to stable-3.31

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	54	54
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	58
Dodgy code	294	294
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	51	51
Security	18	18
Total	502	502

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14229.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.