Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - Observe Download State In Encrypted Folder #14485

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 3, 2025

  • Tests written, or not not needed

Before

before.mp4

After

after.mp4

Known Issue

#14484

@alperozturk96 alperozturk96 changed the title BugFix - Observe Download State BugFix - Observe Download State In Encrypted Folder Feb 3, 2025
@alperozturk96 alperozturk96 requested a review from ZetaTom February 3, 2025 09:41
@alperozturk96
Copy link
Collaborator Author

Link increased due to:
Screenshot 2025-02-03 at 10 55 13

But I didn't touch that file. @tobiasKaminsky

Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/observe-download-state branch from 75547de to b4e6a5c Compare February 5, 2025 13:08
@@ -151,11 +151,11 @@ class PreviewImagePagerAdapter : FragmentStateAdapter {
addVideoOfLivePhoto(file)

if (mDownloadErrors.remove(i)) {
fragment = FileDownloadFragment.newInstance(file, user, true)
fragment = FileDownloadFragment.newInstance(file, user, true, i)
(fragment as FileDownloadFragment).setError(true)
} else {
fragment = if (file.isEncrypted) {
Copy link
Collaborator Author

@alperozturk96 alperozturk96 Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky If I don't use FileDownloadFragment, this happens:

kee.mp4

So better to keep it.

Copy link

github-actions bot commented Feb 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14485.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Feb 5, 2025

Codacy

Lint

TypemasterPR
Warnings5556
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total503503

Lint increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant