Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix - E2EE Delete File #14498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 5, 2025

  • Tests written, or not not needed

Problem

If the user tries to preview an image from the directory, the file cannot be deleted.

How to test?

  1. Create an encrypted folder
  2. Add images into the encrypted folder
  3. Open image from folder
  4. Try to delete image from top right more menu

Signed-off-by: alperozturk <[email protected]>
Copy link

github-actions bot commented Feb 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14498.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Feb 5, 2025

Codacy

Lint

TypemasterPR
Warnings5556
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5757
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5353
Security1818
Total503503

Lint increased!

Copy link

github-actions bot commented Feb 5, 2025

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant