Open Document Timeout #14510
Open
Open Document Timeout #14510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexknop
force-pushed
the
OpenDocumentTimeout
branch
2 times, most recently
from
828feec to
4c559c3
Compare
added 4 commits
February 11, 2025 09:58
Signed-off-by: Alex Knop <[email protected]>
Signed-off-by: Alex Knop <[email protected]>
Signed-off-by: Alex Knop <[email protected]>
alexknop
force-pushed
the
OpenDocumentTimeout
branch
from
4c559c3 to
2b56779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When offline and attempting to open a document via the Document Provider, the wait time is excessive.
CheckEtagRemoteOperation is reporting ETAG_CHANGED when the connection times out to the server, thus triggering needsDownload.
Instead, if the file is saved offline and the etag cannot be read from the server, there is no need for download.
Solution:
Implemented shorter timeouts than the default, which would take longer than is necessary.
If the etag has changed and we have a connection to the server, then result's data will be populated.
We now check whether this data exists.
If data returns null (which results from a timeout), then we return false. This skips the unnecessary download attempt.
Fixes #14478