Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - Check Device Credentials Existance #14536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

BugFix - Check Device Credentials Existance #14536

wants to merge 2 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Feb 11, 2025 •
edited
Loading

  • Tests written, or not not needed

How to reproduce?

  • set a device protection (e.g. PIN or patter)
  • go to app settings
  • enable passcode using device protection
  • close the app
  • remove your local device protection
  • restart the app
  • app will not launch

Changes

  • Remove unnecessary internal boolean flag. Because there is no set method for the PREFERENCE_USE_FINGERPRINT.
  • Fix deviceCredentialsAreEnabled() function condition

Before

before.mp4

After

after.mp4

@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14536.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96
add check
1a9c2b3 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
remove unnecessary checks
fde6aee 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the bugfix/check-device-credentials-existance branch from ea11f44 to fde6aee Compare February 11, 2025 09:46
@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings5454
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness5858
Dodgy code294294
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness77
Performance5151
Security1818
Total502502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperozturk96 @tobiasKaminsky