Handle E2EE Download Key Task Result #14538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
handle-e2ee-download-key-task-result
branch
from
090765e to
d295cb2
Compare
alperozturk96
commented
Feb 11, 2025
| UnexpectedError(R.string.end_to_end_encryption_unexpected_error_occurred) | ||
| } | ||
|
|
||
| // TODO - Replace with Coroutines |
There was a problem hiding this comment.
This will be addressed in different PR.
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14538.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
During the DownloadKeysAsyncTask operation, multiple requests can be sent, which may result in various errors. If these errors are not properly handled, the user might still see the passphrase generation screen, which is incorrect. This PR provides accurate feedback to the user.
In the example given below, the passphrase has already been saved. The issue lies in the private key download task.
Before
before.mp4
After
after.mp4
Generate New Passphrase
gen_new_passphrase.mp4
Use Saved Passphrase
decrpt.mp4