Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

occ app_api:app:register error message #172

Merged
merged 2 commits into from
Dec 19, 2023
Merged

occ app_api:app:register error message #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
089ae87
added check for error from `dockerActions->loadExAppInfo`
bigcat88 Dec 19, 2023
bcec801
reflected fix in changelog
bigcat88 Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,24 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [1.4.4 - 2023-12-xx]

### Added

- Added ability for `requestToExApp` and `aeRequestToExApp` methods, to send `multipart` requests. #168

### Fixed

- invalid default Nextcloud URL, incorrect url with slash at the end processing. #169
- Processing of invalid default Nextcloud URL/incorrect url with slash at the end. #169
- `occ app_api:app:register` error message in case of missing deploy of ExApp. #172

## [1.4.3 - 2023-12-18]

### Added

- links to new apps that uses AppAPI. #158
- added ability for `requestToExApp` and `aeRequestToExApp` methods, to send `multipart` requests. #168
- Links to new apps that uses AppAPI. #158

### Fixed

- invalid timeout condition check for `/init` endpoint. #155
- Invalid timeout condition check for `/init` endpoint. #155

## [1.4.2 - 2023-12-13]

Expand Down
4 changes: 4 additions & 0 deletions lib/Command/ExApp/Register.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int

if ($daemonConfig->getAcceptsDeployId() === $this->dockerActions->getAcceptsDeployId()) {
$exAppInfo = $this->dockerActions->loadExAppInfo($appId, $daemonConfig);
if (array_key_exists('error', $exAppInfo)) {
$output->writeln(sprintf('%sDid application was deployed before registration?', $exAppInfo['error']));
return 2;
}
} elseif ($daemonConfig->getAcceptsDeployId() === $this->manualActions->getAcceptsDeployId()) {
$exAppJson = $input->getOption('json-info');
if ($exAppJson === null) {
Expand Down