Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable4.6] fix(attachments): Convert FileList to array for FireFox #5657

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5656

Firefox does not have FileList.forEach

Signed-off-by: Christoph Wurst <[email protected]>
@backportbot-nextcloud backportbot-nextcloud bot added 3. to review Waiting for reviews bug labels Jan 2, 2024
@backportbot-nextcloud backportbot-nextcloud bot added this to the v4.6.1 milestone Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (151f50f) 15.67% compared to head (3cb5c1c) 15.66%.
Report is 1 commits behind head on stable4.6.

Files Patch % Lines
.../components/Editor/Attachments/AttachmentsList.vue 0.00% 2 Missing ⚠️
src/services/attachmentService.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           stable4.6    #5657      +/-   ##
=============================================
- Coverage      15.67%   15.66%   -0.01%     
=============================================
  Files            202      202              
  Lines           8634     8636       +2     
  Branches        1740     1740              
=============================================
  Hits            1353     1353              
- Misses          7281     7283       +2     
Flag Coverage Δ
javascript 15.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristophWurst ChristophWurst merged commit b424702 into stable4.6 Jan 2, 2024
39 of 41 checks passed
@ChristophWurst ChristophWurst deleted the backport/5656/stable4.6 branch January 2, 2024 16:13
@st3iny st3iny modified the milestones: v4.6.1, v4.6.2 Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants