fix: always show alarm unit in pural #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
added
3. to review
st3iny
requested review from
SebastianKrupinski and
tcitworld
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6752 +/- ##
=========================================
Coverage 23.00% 23.00%
Complexity 476 476
=========================================
Files 252 252
Lines 12174 12174
Branches 2318 2330 +12
=========================================
Hits 2801 2801
Misses 9034 9034
Partials 339 339
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SebastianKrupinski
approved these changes
Feb 20, 2025
I agree, I don't event thing anyone will notice. |
|
/backport to stable5.1 |
|
/backport to stable4.7 |
backportbot
bot
added
the
backport-request
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3441
This is a simple fix for the collision of translations for
second. Please refer to #3441 (comment) for more information.IMO, the impact is minimal and acceptable. Users will only notice it if they create an alarm with a relative time of 1 hour, minute, second, etc.