Add setting of NEXTCLOUD_SERVER and NEXTCLOUD_INFO_APPS for metrics exporter and clean up docs #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
This is an update to the
metrics
section of the values.yaml. This PR covers:adds optionally setting
NEXTCLOUD_SERVER
via themetrics.server
parameter, instead of allowing the chart to template it out from the k8s service. If not provided, we still use the service nameadds setting
NEXTCLOUD_INFO_APPS
via themetrics.info.apps
parameter, which "Enables gathering of apps-related metrics". Defaults to false as it does in the actual container.adds
metrics.replicaCount
to the README, as it was missingformats the tables in the README (because my linter did it by default 😅 )
Benefits
This allows users to get more granular when playing with the metrics exporter container.
Possible drawbacks
none that I can see immediately. open to chatting as usual :)
Applicable issues
not sure we have any issues on this yet?
Additional information
See docs here: https://github.com/xperimental/nextcloud-exporter?tab=readme-ov-file#environment-variables
Checklist
Chart.yaml
according to semver.