Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting of NEXTCLOUD_SERVER and NEXTCLOUD_INFO_APPS for metrics exporter and clean up docs #587

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Jul 1, 2024

Pull Request

Description of the change

This is an update to the metrics section of the values.yaml. This PR covers:

  • adds optionally setting NEXTCLOUD_SERVER via the metrics.server parameter, instead of allowing the chart to template it out from the k8s service. If not provided, we still use the service name

  • adds setting NEXTCLOUD_INFO_APPS via the metrics.info.apps parameter, which "Enables gathering of apps-related metrics". Defaults to false as it does in the actual container.

  • adds metrics.replicaCount to the README, as it was missing

  • formats the tables in the README (because my linter did it by default 😅 )

Benefits

This allows users to get more granular when playing with the metrics exporter container.

Possible drawbacks

none that I can see immediately. open to chatting as usual :)

Applicable issues

not sure we have any issues on this yet?

Additional information

See docs here: https://github.com/xperimental/nextcloud-exporter?tab=readme-ov-file#environment-variables

Checklist

@jessebot jessebot added 3. to review Waiting for reviews enhancement New feature or request labels Jul 1, 2024
@jessebot jessebot requested a review from provokateurin July 1, 2024 07:48
@jessebot jessebot self-assigned this Jul 1, 2024
@jessebot jessebot added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 1, 2024
@jessebot jessebot merged commit cf19396 into main Jul 1, 2024
5 checks passed
@jessebot jessebot deleted the update-metrics-deployment branch July 1, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants