fix: while creating a new account, check for his existance#13187
Open
madbob wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the PR |
Contributor
|
/backport to stable5.10 |
Contributor
|
would it be possible for you to write a quick test about this check? |
Signed-off-by: Roberto Guido <info@madbob.org>
hamza221
approved these changes
Jul 13, 2026
Member
|
What I'm missing
|
Collaborator
Author
I'm going to check.
In my opinion, this cannot be retroactive. What is done, is done.
This implementation just checks that the current user do not register multiple times the same mail account, but no one specified what happens if different users register the same mail account. If allowed: it cannot be unique in the database. If not allowed: this implementation is wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Unsure if the duplication check should span across all existing accounts on the instance, or just those registered by the current user...
Fixes #12042