fix(template-filler): Hide template fields with unknown labels

Signed-off-by: Elizabeth Danzberger <[email protected]> [skip ci]
nextcloud · Feb 13, 2025 · 71110cf · 71110cf
1 parent c7c773b
commit 71110cf
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/apps/files/src/components/TemplateFiller.vue b/apps/files/src/components/TemplateFiller.vue
@@ -4,13 +4,18 @@
 -->
 
 <template>
-	<NcModal>
+	<NcModal label-id="template-field-modal__label">
 		<div class="template-field-modal__content">
 			<form>
-				<h3>{{ t('files', 'Fill template fields') }}</h3>
+				<h3 id="template-field-modal__label">
+					{{ t('files', 'Fill template fields') }}
+				</h3>
 
 				<div v-for="field in fields" :key="field.index">
-					<component :is="getFieldComponent(field.type)" :field="field" @input="trackInput" />
+					<component :is="getFieldComponent(field.type)"
+						v-if="fieldHasLabel(field)"
+						:field="field"
+						@input="trackInput" />
 				</div>
 			</form>
 		</div>
@@ -80,6 +85,9 @@ export default defineComponent({
 
 			return `Template${fieldComponentType}Field`
 		},
+		fieldHasLabel(field) {
+			return field.name || field.alias
+		},
 		async submit() {
 			this.loading = true
 

diff --git a/apps/files/src/components/TemplateFiller/TemplateCheckboxField.vue b/apps/files/src/components/TemplateFiller/TemplateCheckboxField.vue
@@ -40,7 +40,7 @@ export default defineComponent({
 
 	computed: {
 		fieldLabel() {
-			const label = this.field.name ?? this.field.alias ?? 'Unknown field'
+			const label = this.field.name || this.field.alias
 
 			return label.charAt(0).toUpperCase() + label.slice(1)
 		},

diff --git a/apps/files/src/components/TemplateFiller/TemplateRichTextField.vue b/apps/files/src/components/TemplateFiller/TemplateRichTextField.vue
@@ -45,7 +45,7 @@ export default defineComponent({
 
 	computed: {
 		fieldLabel() {
-			const label = this.field.name ?? this.field.alias ?? 'Unknown field'
+			const label = this.field.name || this.field.alias
 
 			return (label.charAt(0).toUpperCase() + label.slice(1))
 		},