perf: Log requests using high amount of memory as warning #48738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
nickvergessen,
a team,
icewind1991,
skjnldsv and
yemkareems
and removed request for
a team
nickvergessen
approved these changes
Oct 16, 2024
solracsf
reviewed
Oct 16, 2024
Merged
AndyScherzinger
force-pushed
the
perf/log-high-memory-requests
branch
from
6a88895 to
8aa28ec
Compare
AndyScherzinger
force-pushed
the
perf/log-high-memory-requests
branch
from
8aa28ec to
75bf7d5
Compare
|
Let me address the comment |
juliusknorr
force-pushed
the
perf/log-high-memory-requests
branch
from
75bf7d5 to
19d8fa7
Compare
solracsf
reviewed
Feb 13, 2025
lib/base.php
Outdated
| }; | ||
| if ($logLevel !== null) { | ||
| $message = 'Request used more than 300 MB of RAM: ' . Util::humanFileSize($memoryPeak); | ||
| $logger = \OCP\Server::get(LoggerInterface::class); |
There was a problem hiding this comment.
Suggested change
| $logger = \OCP\Server::get(LoggerInterface::class); | |
| $logger = Server::get(LoggerInterface::class); |
solracsf
reviewed
Feb 13, 2025
lib/base.php
Outdated
Comment on lines
836
to
838
| $memoryPeak > 500_000_000 => \OCP\ILogger::FATAL, | ||
| $memoryPeak > 400_000_000 => \OCP\ILogger::ERROR, | ||
| $memoryPeak > 300_000_000 => \OCP\ILogger::WARN, |
There was a problem hiding this comment.
Suggested change
| $memoryPeak > 500_000_000 => \OCP\ILogger::FATAL, | |
| $memoryPeak > 400_000_000 => \OCP\ILogger::ERROR, | |
| $memoryPeak > 300_000_000 => \OCP\ILogger::WARN, | |
| $memoryPeak > 500_000_000 => ILogger::FATAL, | |
| $memoryPeak > 400_000_000 => ILogger::ERROR, | |
| $memoryPeak > 300_000_000 => ILogger::WARN, |
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
perf/log-high-memory-requests
branch
from
19d8fa7 to
d31bc88
Compare
solracsf
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help us finding candidates to optimize more easily.