-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): Always try to generate some kind of preview #50622
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
2aef985
to
c75fba9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP changes are legit, but I do not know enough about this to judge the API change implied here.
The API change itself is backwards compatible, since the removed parameters are just ignored now. Any client still sending them will not notice that they are not used anymore. |
It will change the behavior as you now get the 303 for the mimetype even if you do not request it. Not sure if this is bad or not. But a safer approach would be to reduce this to only the folder mime type change. |
You mean because a client would then chose to display it's own mimetype preview? |
Yes especially to get mimetype icons in the current color schema (dark / bright). |
Summary
Instead of providing the option to generate fallback previews this PR changes it to always generate some kind of preview if possible.
I don't see a reason why we shouldn't ever fallback to the mimetype or symbolic icon in case we are not able to generate a proper preview or it's a folder.
This also improves the UX, in case developers forget to manually request the mimeFallback, as now the users still see some preview.
Checklist