chore(filecache): remove index fs_id_storage_size #50791
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
requested review from
artonge,
nfebe and
sorbaugh
and removed request for
a team
Altahrim
added
2. developing
Altahrim
force-pushed
the
perf/remove-filecache-index
branch
2 times, most recently
from
ba26160 to
b6b7e2f
Compare
Index is outdated by PR 50781 Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
perf/remove-filecache-index
branch
from
b6b7e2f to
3548bde
Compare
artonge
approved these changes
Feb 13, 2025
Altahrim
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes index
fs_id_storage_sizeThis index was introduced in #29118 to optimize incomplete scan search.
The request is modified in #50781 and the index isn't necessary anymore.
TODO
Checklist