fix(chat): promptly update messages list in sidebar, store and chat #12632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
- fix from ed3b02c is no longer an issue Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
3. to review
bug
feature: chat 💬
DorraJaouad
reviewed
Jul 2, 2024
DorraJaouad
reviewed
Jul 2, 2024
Antreesy
force-pushed
the
feat/noid/delete-message-reactive
branch
from
3f3f092 to
65c1210
Compare
DorraJaouad
approved these changes
Jul 3, 2024
- less conditions: group no longer exists, did not exist before or different from previous version - re-sort conditions for groups comparison (to make early return on less complex operations Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
feat/noid/delete-message-reactive
branch
from
fe17bde to
4b5daa2
Compare
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
group no longer exists, 2group did not exist before, 3group is different from previous versionTo test:
Tip
Case 1: delete message
Tip
Case 2: delete edited message
Tip
Case 3: drop last commit, post message 1, post message 2, edit message 2, delete message 2
🏁 Checklist