fix(calls): media settings tabs animation #14346
Merged
+1
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tab switch animation only worked when tabs were initially closed, because the animation used to activate only after tabs are open via `enabkleTransition`. Initial value of `enableTransition` should have been defined by the `isOpen` state. However, `enableTransition` controlling animation isn't needed at all. After the component got `active` prop controlling the state and the presence of the `transition` value. Signed-off-by: Grigorii K. Shartsev <[email protected]>
|
/backport to stable31 |
|
/backport to stable30 |
Antreesy
approved these changes
Feb 11, 2025
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Tab switch animation only worked when tabs were initially closed because the animation used to activate only after tabs are open via
enabkleTransition.Initial value of
enableTransitionshould have been defined by theisOpenstate.However,
enableTransitioncontrolling animation isn't needed at all. After the component gotactiveprop controlling the state and the presence of thetransitionvalue.🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist