Feat/styling right click menu #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A quick screenshot would be generally appreciated for any UI changes :) |
juliusknorr
reviewed
Aug 16, 2024
src/App.scss
Outdated
| } | ||
|
|
||
| .excalidraw .context-menu-item-separator { | ||
| border-top: 0.5px solid #adb5bd !important; |
There was a problem hiding this comment.
Suggested change
| border-top: 0.5px solid #adb5bd !important; | |
| border-top: 0.5px solid var(--color-border) !important; |
juliusknorr
reviewed
Aug 16, 2024
src/App.scss
Outdated
Comment on lines
134
to
135
| margin-top: 0.25rem !important; | ||
| margin-bottom: 0.25rem !important; |
There was a problem hiding this comment.
Ideally we'd use spacing values that are calculated from --default-grid-baseline https://docs.nextcloud.com/server/latest/developer_manual/html_css_design/css.html#element-structure-variables
juliusknorr
reviewed
Aug 16, 2024
src/App.scss
Outdated
|
|
||
| .excalidraw .context-menu-item:hover { | ||
| background-color: var(--color-background-hover) !important; | ||
| border-radius: 6px !important; |
juliusknorr
approved these changes
Aug 16, 2024
Signed-off-by: Hoang Pham <[email protected]>
hweihwang
force-pushed
the
feat/styling-right-click-menu
branch
from
4e3ce4b to
f7fc3dc
Compare
juliusknorr
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some screenshots of how it looks, not sure if it's okay :)
Full menu:
Partial:
Mobile:
Hover:
