Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add setup check to verify whiteboard backend server version and connectivity #297

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 6, 2024

This should help us detect a few pitfalls with the setup

  • Detect if the Nextcloud app and backend server versions are not in sync
  • Detect if the Nextcloud server can properly connect to the whiteboard server
  • Detect if the whiteboard server can connect back to the Nextcloud server

The setup check is indicating problems now in the admin overview as well as when running occ setupcheck and when going to the whiteboard admin settings.

Fix #144

Adds some checks for parts of #238

Screenshot 2025-02-13 at 08 00 33

@hweihwang
Copy link
Contributor

When I tested a bit, it kept saying failed to connect to whiteboard server even the whiteboard working fine. Seems the checks doing a curl from nextcloud backend to whiteboard server, not entirely sure but should it be a check from frontend to whiteboard server @juliusknorr (Maybe one check/call from FE => status endpoint of whiteboard server)

@juliusknorr
Copy link
Member Author

juliusknorr commented Dec 12, 2024

  • Need to check connectivity issues with docker when the node process is running outside of it

Sorry, something went wrong.

@juliusknorr
Copy link
Member Author

juliusknorr commented Feb 13, 2025

I did a bit more work here that also introduces a bit more flexibility in configuring. We now allow a separate internal URL of the whiteboard server (optional with a fallback for the regular one). This can be used in setups where the Nextcloud server may need a separate hostname/ip to reach the whiteboard server compared to the browser.

Newly added:

  • Setting to configure the internal URL
  • Setting to skip TLS certificate validation
  • Restructure settings a bit more
  • Setup check error when not configured

Example config for running nextcloud in docker but whiteboard outside:

Screenshot 2025-02-13 at 07 44 22

Screenshots of the setup warning in the admin overview:

Screenshot 2025-02-13 at 07 51 18 Screenshot 2025-02-13 at 07 51 05

@juliusknorr juliusknorr force-pushed the feat/setup-check branch 2 times, most recently from 815712f to db0da02 Compare February 13, 2025 07:08

Verified

This commit was signed with the committer’s verified signature.
… connectivity

Signed-off-by: Julius Knorr <jus@bitgrid.net>
Copy link
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, this is gonna help a lot triaging issues 🔥

@juliusknorr juliusknorr merged commit 9ef3b98 into main Feb 13, 2025
28 checks passed
@juliusknorr juliusknorr deleted the feat/setup-check branch February 13, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check backend version
3 participants