-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Azure Batch worker pool supports managed identity #5670
Open
adamrtalbot
wants to merge
5
commits into
nextflow-io:master
Choose a base branch
from
adamrtalbot:pass_managed_identity_client_id_to_azure_pool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[draft] Azure Batch worker pool supports managed identity #5670
adamrtalbot
wants to merge
5
commits into
nextflow-io:master
from
adamrtalbot:pass_managed_identity_client_id_to_azure_pool
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds an option to tell Azure Batch the worker pool has a managed identity attached. Currently, the only feature is it passes the managed identity client id to the task as an environment variable but this could be extended to support file staging in or out. Signed-off-by: adamrtalbot <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: adamrtalbot <[email protected]>
No longer requires SAS tokens for file staging, it can use the managed identity to authenticate. Signed-off-by: adamrtalbot <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
This was
linked to
issues
Jan 14, 2025
Hello, |
5a93547
to
27345a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds an option to tell Azure Batch the worker pool has a managed identity attached.
azcopy needs to be updated, since the current version isn't recent enough.
When using this feature, you can tell Nextflow that a node pool has a managed identity attached:
it will then use the native azcopy managed identity authentication to download and upload files.
I haven't handled all the old code yet, so Nextflow will generate a SAS which it only uses sometimes.
Importantly, this 'fixes' #5669, because it doesn't need a SAS token to access the files (tested).
To use:
bash -c "tar -xzvf azcopy.tar.gz && chmod +x azcopy*/azcopy && mkdir -p $AZ_BATCH_NODE_SHARED_DIR/bin/ && cp azcopy*/azcopy $AZ_BATCH_NODE_SHARED_DIR/bin/"
azcopy.tar.gz
my-pool
:To do: