feat(azure-batch): Ignore pool already exists error #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignores pool already exists error and continues. Fixes nextflow-io#5713 Signed-off-by: adamrtalbot <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bentsherman
reviewed
Feb 6, 2025
| @@ -711,77 +711,85 @@ class AzBatchService implements Closeable { | |||
| } | |||
|
|
|||
| protected void createPool(AzVmPoolSpec spec) { | |||
| try { | |||
There was a problem hiding this comment.
Generally speaking, when a long function needs to be wrapped in a try-catch like this, we like to put the try-catch in a separate wrapper function:
protected void safeCreatePool(AzVmPoolSpec spec) {
try {
createPool(spec)
}
catch( HttpResponseException e ) {
// ...
}
}
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
5a93547 to
27345a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores pool already exists error and continues. Fixes #5713
I can't get the mocks working for the tests :(