Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wave client): Support local manifests in FUSION_CONTAINER_CONFIG_URL #5738

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alberto-miranda
Copy link
Contributor

@alberto-miranda alberto-miranda commented Feb 3, 2025

Description

This PR enables Nextflow to accept local files as an additional source for FUSION_CONTAINER_CONFIG_URL. This can be useful for testing fusion and also for offline deployments. Local files can be specified using the file:// schema or with no schema at all.

Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit f8d081a
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67a106b0c26def0008db6c42
😎 Deploy Preview https://deploy-preview-5738--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alberto-miranda alberto-miranda marked this pull request as draft February 3, 2025 18:11
@pditommaso
Copy link
Member

Please add some context and description

@alberto-miranda alberto-miranda changed the title feat: Support local manifests in FUSION_CONTAINER_CONFIG_URL feat(fusion_config): Support local manifests in FUSION_CONTAINER_CONFIG_URL Feb 3, 2025
@alberto-miranda
Copy link
Contributor Author

alberto-miranda commented Feb 3, 2025

Please add some context and description

Apologies @pditommaso, it wasn't my intention to create a PR yet but the cat's now out of the bag 😅

@alberto-miranda alberto-miranda changed the title feat(fusion_config): Support local manifests in FUSION_CONTAINER_CONFIG_URL feat(wave client): Support local manifests in FUSION_CONTAINER_CONFIG_URL Feb 3, 2025
@alberto-miranda
Copy link
Contributor Author

Description updated.

@alberto-miranda
Copy link
Contributor Author

Tests and docs coming only if this PR is actually useful 🤞

@pditommaso pditommaso force-pushed the master branch 2 times, most recently from 5a93547 to 27345a6 Compare February 10, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants