Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for multi-platform images take two #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shenato
Copy link
Contributor

@Shenato Shenato commented Apr 7, 2022

Hey it's me again,

I've finally figured out how to add the multi-platform support with very minor changes to the repository's structure and outputs

The new method:

  • Build and push a multiplatform image to github packages, since docker can't deal with multi-platform images locally.
  • Pull the image for whatever platform the Github action is running on (most likely amd64 i assume) and testing it.
  • If no failures occur so far, it will tag it the same way as before on Github packages registry, then it will copy it and push it to docker hub as well.

everything else is relatively untouched.

NOTE: This requires extra privileges than GITHUB_TOKEN could provide, therefore i believe you need a personal access token of some sort to be added to this repository as a secret under the name DOCKER_DEPLOYER (we can change the name if you want, that's no issue) so that this action will be able to tag images remotely on Github Packages registry formerly known as Github docker registry

Perhaps I'm wrong and it will work just fine with GITHUB_TOKEN, but it failed for me every single time I've used it.

I've tested this in my own repository and can confirm it works. there may be authentication issues related to the GITHUB_TOKEN but I've stated above in the note how I've handled that.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant