Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional enhancement: Redesign or refactor state-specific rules into the core workflow #64

Open
j23414 opened this issue Feb 5, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@j23414
Copy link
Collaborator

j23414 commented Feb 5, 2025

Context

Currently, supporting state specific builds (PR which was merged on January 20th, 2025) was fast-tracked by splitting out state-specific rules into a custom rules file:

Optional future work was to refactor these rules such that they are either incorporated into the core workflow, converted to config-only changes, or dropped. Leaving these as custom rules would require explanation for other states to support their own builds, perhaps a benefit if they need their own custom items.

Description

  • Pro for a refactor: Refactoring the state-specific rules into the core workflow would reduce the need for separate, state-specific rule files, making maintenance easier. This option would require rethinking how zip code lat/long values are being averaged by district, state, region. Some logic may be common across other state builds and incorporating into the core workflow would eliminate unnecessary duplication.
  • Con for a refactor: Leaving these as custom rules provides an example for states to incorporate their own custom rules. They can still be directed to use the core workflow by only passing in a config.yaml file with their state-focused subsampling. Leaving these state-specific rules as custom files requires less development effort and would allow us to work on more high priority tasks.

Examples

Possible solution

@j23414 j23414 added the enhancement New feature or request label Feb 5, 2025
@j23414 j23414 changed the title Optional enhancement: Redesign or refactor state-specific rules into the main workflow Optional enhancement: Redesign or refactor state-specific rules into the core workflow Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant