Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show progress during check-setup #359

Open
corneliusroemer opened this issue Feb 1, 2024 · 3 comments · May be fixed by #418
Open

Show progress during check-setup #359

corneliusroemer opened this issue Feb 1, 2024 · 3 comments · May be fixed by #418
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

nextstrain check-setup takes almost a minute despite having a fast M1 Pro. There's no progress indicator which might be confusing to users who are running it for the first time.

It might be good to give an indication how long this check takes. E.g. "Testing your setup... (this takes about a minute)"

Even better would be some sort of progress indication after each runtime is checked, maybe outputting it or indicating that it has been checked successfully.

image
@corneliusroemer corneliusroemer added the enhancement New feature or request label Feb 1, 2024
@tsibley
Copy link
Member

tsibley commented Feb 1, 2024

Yeah, check-setup hasn't gotten a lot of attention. It could use some!

tsibley added a commit that referenced this issue Feb 2, 2024
Conditions on the Nextstrain CLI version being requested, as aarch64
builds¹ will only be available going forward for new releases.  Assumes
the next release will be 8.2.0!

Disables Rosetta check when using an aarch64 build, as the checks will
be done at the runtime-level instead by `nextstrain setup` and
`nextstrain check-setup`.²

We must wait to merge this until after the first release (i.e. 8.2.0) of
the changes it depends on above.

¹ <#357>
² <#359>
@victorlin
Copy link
Member

victorlin commented Feb 6, 2025

I didn't realize there was an existing issue for this. I hacked together d4e5a78 a while back and this is what it looks like, before and after. Note that only conda and ambient are fully unbuffered, but the same can apply to other runtimes as well.

demo.mov

If others think this is a good direction, I can turn it into a proper PR.

@tsibley
Copy link
Member

tsibley commented Feb 13, 2025

@victorlin Generally in favor of that direction. Note that I've made some changes to the setup/runner tests in #407 (896c2a6), but they're straightforward renames and I can rebase on top of your changes for this if needed. Probably I should pull out several of the ancillary changes from that branch into a new one and get them merged before the workflows-as-programs features.

@victorlin victorlin linked a pull request Feb 13, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants