-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address removal of augur export v1
for private.nextflu.org builds
#213
Comments
I think this would be minimal work - |
Good to know! I haven't dug into the specific imports, so I wasn't sure how much we would need to copy over.
I've already blocked this work before...clearly it won't get prioritized unless we set a deadline 😅 Not sure we want to wait on long term solution of removing the private site, so happy to go with the medium term solution of vendoring |
Echoing James – I don't see a need to remove |
Context
augur export v1
will be removed soon, but we still use it in the private.nextflu.org build.Possible solutions
Short term
We can pin the docker image used in the private nextflu workflow to a docker-base image that still has a version of Augur that has
augur export v1
.We cannot do this indefinitely because the private nextflu workflow is built on top of the core workflow. If we make backwards-incompatible changes the in the core workflow (e.g. use the new refine
--remove-outgroup
flag) that are not available in the pinned version of Augur, then the workflow will fail. (Edit: I guess we could pin the private nextflu workflow to a commit to work around this, but that will prevent us from updating the source files like reference strains. Sounds like a bad set up!)Medium term
Keep
augur export v1
as a custom script in this repo to continue using it in the workflow.Long term
Sunset private.nextflu.org
The text was updated successfully, but these errors were encountered: