Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release PR v1.5.1 #165

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Release PR v1.5.1 #165

merged 5 commits into from
Mar 7, 2024

Conversation

nvnieuwk
Copy link
Member

@nvnieuwk nvnieuwk commented Mar 5, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nvnieuwk nvnieuwk requested a review from matthdsm March 5, 2024 10:11
matthdsm
matthdsm approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me if tests pass

@nvnieuwk
Copy link
Member Author

nvnieuwk commented Mar 5, 2024

Linting issues are caused by a bug in nf-core/tools

@nvnieuwk nvnieuwk merged commit f7ce20f into master Mar 7, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthdsm matthdsm matthdsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @matthdsm