Firstpipe module #35
Merged
Firstpipe module #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olumn_wise_combination
… as keys when they are not unique in the Json
… does not brake code
mathysgrapotte
approved these changes
Mar 15, 2024
| @@ -83,7 +84,143 @@ def _check_params_schema(self) -> int: | |||
| return num_params_list[0] | |||
| else: | |||
| raise ValueError(f"Expected the same number of values for all the params under noise value, but received a discordant ammount instead.") | |||
|
|
|||
|
|
|||
| def _transform_noise_dict(self): | |||
There was a problem hiding this comment.
Should be transform_noise_dict without "_" since this calls self.
| def _transform_noise_dict(self): | ||
| """ | ||
| TODO helper fucntion section | ||
| """ |
There was a problem hiding this comment.
This should provide enough documentation with examples
|
|
||
|
|
||
|
|
||
| def _handle_parameter_selection(self, d: dict, param_index: int) -> dict: |
There was a problem hiding this comment.
This should not have "_" as it calls self in the arguments
| """ | ||
| works on the self.noise_arg dictionary to compute all possible combinations of parameters and nboisers in a all against all fashion. | ||
| """ | ||
|
|
There was a problem hiding this comment.
Possible to write an issue about this ?
| """ | ||
| TODO add description | ||
| """ | ||
|
|
There was a problem hiding this comment.
Possible to write an issue about this ?
bin/launch_interpret_json.py
Outdated
| #print(schema.experiment, schema.interpret_params_mode, schema.column_names) | ||
|
|
||
|
|
There was a problem hiding this comment.
Ideally, prints should not be used and replaced by a logger if you are using those to debug (see https://docs.python.org/3/howto/logging.html )
…er or combinations of one present and not hte other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingnore print please. The split reading is not yet done tis is just to process the noise part of the script. Look at examples user_given.json to see an json with all possibilities of values and parameters.