Add add_split method inside CsvProcessing and corresponding tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathysgrapotte
approved these changes
Mar 18, 2024
| """ | ||
| if ('split' in self.categories) and (not force): | ||
| raise ValueError(f"The category split is already present in the csv file. If you want to still use this function, set force=True") | ||
|
|
There was a problem hiding this comment.
We discussed that csv already present should raise a warning and not an error, I will merge as is but this should be modified in the future.
| def __init__(self, experiment: Any, csv_path: str) -> None: | ||
| super().__init__(experiment, csv_path) | ||
| self.data = self.load_csv() | ||
|
|
||
|
|
||
| def add_split(self, split_method: str, split: list, seed: float = None, force=False) -> None: |
There was a problem hiding this comment.
Name doesnt feel too intuitive for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.