Release 1.1.0 - Resolution Road #105
Open
+3,965
−2,232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync dev to master
Co-authored-by: Florian Wuennemann <[email protected]>
Merging template updates, dev version bump after release, module update
Co-authored-by: Florian Wuennemann <[email protected]>
Fixed multiqc report
Mindagap skip
|
|
you seem to have CI issues, is that planned or normal? |
|
It was not expected, in a template update, I changed the CI and skipped conda only on dev, I opened a PR with the fix: #106 |
@maxulysse Not planned. Forgot to disable conda for the full pipeline test. Will make fix and add to this PR 👍🏻 ! |
Exclude conda from all tests.
|
@maxulysse All checks green now ✅ ! |
maxulysse
reviewed
Mar 4, 2025
maxulysse
reviewed
Mar 4, 2025
maxulysse
reviewed
Mar 4, 2025
maxulysse
reviewed
Mar 4, 2025
maxulysse
reviewed
Mar 4, 2025
maxulysse
reviewed
Mar 4, 2025
tests/main.nf.test
Outdated
There was a problem hiding this comment.
nft-utils would make the snapshots both easier and more complete
There was a problem hiding this comment.
Can you be a bit more specific here? What exactly from nft-utils would help here. Is that something we can do for the next release or you think it would help for this version?
There was a problem hiding this comment.
basically follow this logic:
https://github.com/nf-core/sarek/blob/master/tests/default.nf.test#L1-L41
remove
https://github.com/nf-core/sarek/blob/master/tests/default.nf.test#L22-L24
and
https://github.com/nf-core/sarek/blob/master/tests/default.nf.test#L36-L37
That will capture ALL the files produced by the pipeline
You will need a .nftignorefile such as https://github.com/nf-core/sarek/blob/master/tests/.nftignore
and you adapt the non stable files with its content
maxulysse
reviewed
Mar 4, 2025
| @@ -4,3 +4,4 @@ | |||
| ======================================================================================== | |||
| */ | |||
|
|
|||
| trace.overwrite = true | |||
maxulysse
reviewed
Mar 4, 2025
Co-authored-by: Maxime U Garcia <[email protected]>
lpantano
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update the master branch for the next release 1.1.0 Resolution Road.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).